This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA 03/10] Allow elision of some filtered frames
- From: Pedro Alves <palves at redhat dot com>
- To: Tom Tromey <tom at tromey dot com>, gdb-patches at sourceware dot org
- Date: Tue, 27 Jun 2017 17:40:01 +0100
- Subject: Re: [RFA 03/10] Allow elision of some filtered frames
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx03.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx03.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=palves at redhat dot com
- Dkim-filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 46BDC7DCF0
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 46BDC7DCF0
- References: <20170425194113.17862-1-tom@tromey.com> <20170425194113.17862-4-tom@tromey.com>
On 04/25/2017 08:41 PM, Tom Tromey wrote:
> When a frame filter elides some frames, they are still printed by
> "bt", indented a few spaces. PR backtrace/15582 notes that it would
> be nice for users if elided frames could simply be dropped. This
> patch adds this capability.
>
So "bt elide" means "elide the elided frames", not "show me the
elided frames too". It's fine with me, though I mildly wonder whether
users will be confused by the "double negative".
> diff --git a/gdb/extension.h b/gdb/extension.h
> index 2c79411..7c35502 100644
> --- a/gdb/extension.h
> +++ b/gdb/extension.h
> @@ -100,6 +100,9 @@ enum frame_filter_flags
>
> /* Set this flag if frame locals are to be printed. */
> PRINT_LOCALS = 8,
> +
> + /* Set this flag if elided frames should not be printed. */
> + PRINT_ELIDE = 32,
Looks like 16 was elided. :-)
LGTM.
Thanks,
Pedro Alves