Re: [PATCH 06/25] Generate c for feature instead of tdesc

[Yao Qi <qiyaoltc at gmail dot com>]

Pedro Alves <palves@redhat.com> writes:

> "*.xml.tmp.tmp" to "*.xml.tmp".  I.e., from $@.tmp to $@, just
> like the rule further above.
>

Oh, I know what you mean.

> I may be missing something, but AFAICS, the "%.xml.tmp: %.xml"
> rule is writing to the target directly.  If the build
> is interrupted in the middle of that rule, we end up with an
> incomplete "%.xml.tmp" file left over in the file system.
> Then the next time you invoke make, make will think that
> the "%.xml.tmp" file is already up to date and won't rebuild it.
> As a result, you'll pass a broken xml.tmp file to
> "maint print c-tdesc".
>
> Avoiding these issues is the whole point of move-if-change,
> by atomically creating the target file.

move-if-change is needed here.  Let me add it.

-- 
Yao (齐尧)