This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [RFA 1/2] C++-ify break-catch-sig

From: Tom Tromey <tom at tromey dot com>
To: Simon Marchi <simon dot marchi at polymtl dot ca>
Cc: Tom Tromey <tom at tromey dot com>, gdb-patches at sourceware dot org
Date: Mon, 05 Jun 2017 07:12:56 -0600
Subject: Re: [RFA 1/2] C++-ify break-catch-sig
Authentication-results: sourceware.org; auth=none
References: <20170604225353.18008-1-tom@tromey.com> <20170604225353.18008-2-tom@tromey.com> <4bbbfc1a66bb3d2432cdac491a677053@polymtl.ca>

Simon> Although I'd prefer if you used "gdb_signal" instead of "auto"
Simon> here.  It's not much longer, is more expressive.  There are a few
Simon> instances of this throughout the patch.

I made this change.  You might want to change the other uses of for/auto
already in gdb.

Tom

References:
- [RFA 0/2] C++-ify some breakpoint subclasses a bit more
  - From: Tom Tromey
- [RFA 1/2] C++-ify break-catch-sig
  - From: Tom Tromey
- Re: [RFA 1/2] C++-ify break-catch-sig
  - From: Simon Marchi

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]