Re: [PATCH v2 00/19] Various DWARF piece fixes

[Andreas Arnez <arnez at linux dot vnet dot ibm dot com>]

On Tue, May 30 2017, Simon Marchi wrote:

> I went over the patches that Yao hasn't replied on, namely 13, 14, 16, 17
> and 19, it all looks good to me (note the little comment on #17).  Since
> it's some tricky code, I wasn't always able to convince myself of the
> correctness by just looking at it.  But I went through the test cases by
> hand, when applicable, and it gives me enough confidence that the code is
> correct (or at least more correct than the current code :)).

Thanks a lot for looking at this!

> I'm not sure I like the merge of the two functions, already scary by
> themselves, in one scarier monster, but I understand the downsides of
> having two separate functions, so I'm ok to go with it.

Yeah, it's a trade-off.

> I'll let Yao decide if he wants to go himself through the remaining
> patches.

OK, I guess I'll wait a few more days for further feedback from Yao (or
others).

--
Andreas