This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Fix usage of to_string() for pretty-printers with children
- From: Eli Zaretskii <eliz at gnu dot org>
- To: Peter Linss <peter@elemental.software>
- Cc: gdb-patches at sourceware dot org
- Date: Thu, 25 May 2017 21:12:44 +0300
- Subject: Re: [PATCH] Fix usage of to_string() for pretty-printers with children
- Authentication-results: sourceware.org; auth=none
- References: <DA4CEF9D-0714-4EA8-A08A-A3F02B923269@elemental.software> <83shjtkmo8.fsf@gnu.org> <33B79B83-FB3D-4385-8B13-3BC10F8C58D1@elemental.software>
- Reply-to: Eli Zaretskii <eliz at gnu dot org>
> From: Peter Linss <peter@elemental.software>
> Date: Thu, 25 May 2017 10:51:26 -0700
> Cc: gdb-patches@sourceware.org
>
> > Please add back the comma removed here.
> >
> > The documentation part is approved with this gotcha fixed.
> >
> > Thanks.
>
> Revised patch with comma restored (not sure if you want a new email thread for small patch revisions like this):
Thanks, this is OK. For the future, when I say "approved with that
fixed", there's no need to post the corrected patch, just be sure to
correct it before pushing.