This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH v2 10/19] write_pieced_value: Transfer least significant bits into bit-field

From: Yao Qi <qiyaoltc at gmail dot com>
To: Andreas Arnez <arnez at linux dot vnet dot ibm dot com>
Cc: gdb-patches at sourceware dot org
Date: Tue, 16 May 2017 10:14:54 +0100
Subject: Re: [PATCH v2 10/19] write_pieced_value: Transfer least significant bits into bit-field
Authentication-results: sourceware.org; auth=none
References: <1494352015-10465-1-git-send-email-arnez@linux.vnet.ibm.com> <1494352015-10465-11-git-send-email-arnez@linux.vnet.ibm.com>

Andreas Arnez <arnez@linux.vnet.ibm.com> writes:

> gdb/ChangeLog:
>
> 	* dwarf2loc.c (write_pieced_value): When writing to a bit-field,
> 	transfer the source value's least significant bits, instead of its
> 	lowest-addressed ones.  Rename type_len to max_offset.
> 	(read_pieced_value): Mirror above changes to write_pieced_value as
> 	applicable.

LGTM.

-- 
Yao (齐尧)

References:
- [PATCH v2 00/19] Various DWARF piece fixes
  - From: Andreas Arnez
- [PATCH v2 10/19] write_pieced_value: Transfer least significant bits into bit-field
  - From: Andreas Arnez

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]