This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v2 2/2] Rearrange gdb/configure.nat to make it simpler and less redundant
- From: Sergio Durigan Junior <sergiodj at redhat dot com>
- To: Pedro Alves <palves at redhat dot com>
- Cc: GDB Patches <gdb-patches at sourceware dot org>, Simon Marchi <simon dot marchi at polymtl dot ca>, John Baldwin <jhb at freebsd dot org>
- Date: Fri, 05 May 2017 00:22:52 -0400
- Subject: Re: [PATCH v2 2/2] Rearrange gdb/configure.nat to make it simpler and less redundant
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx06.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx06.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=sergiodj at redhat dot com
- Dkim-filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 6064C3D954
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 6064C3D954
- References: <20170425202309.15771-1-sergiodj@redhat.com> <20170503034931.4515-1-sergiodj@redhat.com> <20170503034931.4515-3-sergiodj@redhat.com> <4232d2a4-1199-f258-1fb4-80e6c934971d@redhat.com>
On Thursday, May 04 2017, Pedro Alves wrote:
> On 05/03/2017 04:49 AM, Sergio Durigan Junior wrote:
>> The previous commit introduced gdb/configure.nat, but it was just a
>> copy-and-past (with the necessary adjustments) from the files under
>> gdb/config/. We can do better than that.
>>
>> Instead of using one big 'case' statement that matches the
>> ${gdb_host_cpu} and then match each ${gdb_host}, it is possible to
>> remove a lof of redundancy by matching the most common ${gdb_host}'s
>> first, setting the common variables for each, and then proceed to
>> matching specific ${gdb_host}'s and ${gdb_host_cpu}'s. In other
>> words, reverse the order of the 'case's and take advantage of the fact
>> that a lot of parameters are the same for each host.
>>
>> This commit was tested on x86_64 without regressions.
>>
>> yyyy-mm-dd Sergio Durigan Junior <sergiodj@redhat.com>
>>
>> * configure.nat: Rearrange 'case' statements to make the code
>> simpler and less redundant.
>
> Should probably say instead:
>
> * configure.nat: Rearrange 'case' statements to match
> host before cpu.
>
> This one's OK with that and with the nit John pointed out fixed.
Thanks, I updated the ChangeLog entry accordingly.
> Please make sure that a build that _doesn't_ include the
> native target still builds before pushing.
Tested compiling with --enable-targets=aarch64-unknown-linux and it
worked as expected.
Thanks,
--
Sergio
GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36
Please send encrypted e-mail if possible
http://sergiodj.net/