This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 8/11] Add FRV_MAX_REGISTER_SIZE
- From: Alan Hayward <Alan dot Hayward at arm dot com>
- To: Pedro Alves <palves at redhat dot com>
- Cc: Yao Qi <qiyaoltc at gmail dot com>, "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>, nd <nd at arm dot com>
- Date: Wed, 3 May 2017 11:36:36 +0000
- Subject: Re: [PATCH 8/11] Add FRV_MAX_REGISTER_SIZE
- Authentication-results: sourceware.org; auth=none
- Authentication-results: redhat.com; dkim=none (message not signed) header.d=none;redhat.com; dmarc=none action=none header.from=arm.com;
- Nodisclaimer: True
- References: <3B3BD949-1C9D-44FF-AB6A-03091ECA49D0@arm.com> <867f2rw9br.fsf@gmail.com> <EBF2EEFF-20D5-43F3-B35D-5BB37C3CB153@arm.com> <22BD364F-A9A9-4E21-BC47-96A320760640@arm.com> <86d1bqba87.fsf@gmail.com> <ff095f3a-aa63-7d23-5edc-167f16cbacf7@redhat.com> <CE496FA1-0D8A-47DC-B8E5-91598F30C93E@arm.com> <c5d20ea3-bc8c-6ff2-cf9b-10ca3768b2dc@redhat.com>
- Spamdiagnosticmetadata: NSPM
- Spamdiagnosticoutput: 1:99
> On 3 May 2017, at 12:23, Pedro Alves <palves@redhat.com> wrote:
>
> On 05/03/2017 11:56 AM, Alan Hayward wrote:
>
>>> BTW, note that gdbserver has an equivalent function, called
>>> "supply_register_zeroed".
>
>> +/* Supply register REGNUM with zeroed value to REGCACHE. This is not the same
>> + as calling raw_supply with NULL (which will set the state to
>> + unavailable). */
>> +
>> +void
>> +regcache::raw_supply_zero (int regnum)
>
> A very minor detail, but I'd prefer it if gdb and gdbserver agreed
> on terminology. Should we call this one "zeroed" too, or
> rename gdbserver's to "zero"?
>
> Thanks,
> Pedro Alves
>
I’m happy to update raw_supply to raw_supply_zeroed.
I think that sounds better too.
Alan.