This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA] Change frame_filter_flags to use DEF_ENUM_FLAGS_TYPE
- From: Pedro Alves <palves at redhat dot com>
- To: Sergio Durigan Junior <sergiodj at redhat dot com>, Tom Tromey <tom at tromey dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Fri, 28 Apr 2017 11:56:42 +0100
- Subject: Re: [RFA] Change frame_filter_flags to use DEF_ENUM_FLAGS_TYPE
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx06.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx06.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=palves at redhat dot com
- Dkim-filter: OpenDKIM Filter v2.11.0 mx1.redhat.com D36F33B707
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com D36F33B707
- References: <20170427231728.27581-1-tom@tromey.com> <8737cttcxh.fsf@redhat.com>
On 04/28/2017 04:43 AM, Sergio Durigan Junior wrote:
> On Thursday, April 27 2017, Tom Tromey wrote:
>
>> This changes frame_filter_flags to use DEF_ENUM_FLAGS_TYPE, and
>> updates all the uses. It also changes the enum constants to use <<,
>> as suggested by Sergio.
>
> Hey, that's awesome, Tom. Thanks for doing this; also, very good to use
> DEF_ENUM_FLAGS_TYPE. This will make it prettier when printing these
> values on GDB.
(and catch misuses at compile time.)
>
> LGTM.
To me too.
Thanks,
Pedro Alves