This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA 1/2] Use a distinguishing name for minidebug objfile
- From: Pedro Alves <palves at redhat dot com>
- To: Tom Tromey <tom at tromey dot com>, gdb-patches at sourceware dot org
- Date: Tue, 18 Apr 2017 18:42:32 +0100
- Subject: Re: [RFA 1/2] Use a distinguishing name for minidebug objfile
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx01.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx01.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=palves at redhat dot com
- Dkim-filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 943C28124F
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 943C28124F
- References: <20170413041504.14435-1-tom@tromey.com> <20170413041504.14435-2-tom@tromey.com>
On 04/13/2017 05:15 AM, Tom Tromey wrote:
> One part of PR cli/19951 is that the mini debug info objfile reuses the
> name of the main objfile from which it comes. This can be seen because
> gdb claims to be reading symbols from the same file two times, like:
>
> Reading symbols from /bin/gdb...Reading symbols from /bin/gdb...(no debugging symbols found)...done.
>
> I think this would be less confusing if the minidebug objfile were given
> a different name. That is what this patch implements. It also arranges
> for the minidebug objfile to be marked OBJF_NOT_FILENAME.
Could you update the commit log to also show how things look
after the patch? I could guess it after staring at the patch for
a bit, but it'd be nice to be explicit.
Otherwise LGTM.
Thanks,
Pedro Alves