Re: [PATCH 5/9] Restrict m68k_convert_register_p

[Simon Marchi <simon dot marchi at polymtl dot ca>]

On 2017-04-13 03:26, Yao Qi wrote:
> @@ -203,17 +205,6 @@ m68k_register_to_value (struct frame_info *frame,
> int regnum,
>    struct type *fpreg_type = register_type (get_frame_arch (frame),
>  					   M68K_FP0_REGNUM);
>
> -  /* We only support floating-point values.  */
> -  if (TYPE_CODE (type) != TYPE_CODE_FLT)
> -    {
> -      warning (_("Cannot convert floating-point register value "
> -	       "to non-floating-point type."));
> -      *optimizedp = *unavailablep = 0;
> -      return 0;
> -    }

Perhaps that can be replaced with a gdb_assert (TYPE_CODE (type) == 
TYPE_CODE_FLT) ?  Or maybe it would be more appropriate to put such 
asserts on convert_typed_floating ?

Likewise in the following patches, the if (TYPE_LENGTH (valtype) == 4) 
check in alpha could be replaced with gdb_assert (TYPE_LENGTH (valtype) 
== 4).

Simon