This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 0/8] Python bindings for GDB record
- From: Eli Zaretskii <eliz at gnu dot org>
- To: Tim Wiederhake <tim dot wiederhake at intel dot com>
- Cc: gdb-patches at sourceware dot org, markus dot t dot metzger at intel dot com, brobecker at adacore dot com, qiyaoltc at gmail dot com
- Date: Thu, 13 Apr 2017 18:20:13 +0300
- Subject: Re: [PATCH 0/8] Python bindings for GDB record
- Authentication-results: sourceware.org; auth=none
- References: <1492095516-8650-1-git-send-email-tim.wiederhake@intel.com>
- Reply-to: Eli Zaretskii <eliz at gnu dot org>
> From: Tim Wiederhake <tim.wiederhake@intel.com>
> Cc: markus.t.metzger@intel.com, brobecker@adacore.com, qiyaoltc@gmail.com
> Date: Thu, 13 Apr 2017 16:58:28 +0200
>
> This patch series addresses the design issues with the Python bindings for
> GDB record, as discussed here:
> https://sourceware.org/ml/gdb-patches/2017-04/msg00171.html
>
> The first three patches are fixing random stuff I came across while working on
> the design issues.
> Patch #4 removes the "ptid" attribute from gdb.Record. Patch #5 introduces a
> new "gdb.RecordGap" class. Patches #6 and #7 rename and rework the Python
> classes for a recorded instruction / function call segment and lastly, patch
> #7 introduces a generic "gdb.Instruction" class as a base for the recorded
> instruction class.
>
> Regards,
> Tim
>
> Tim Wiederhake (8):
> Python: Fix indentation in py-record-btrace.c
> Python: Fix exception handling in py-record-btrace.c
> Python: Use correct ptid in btrace recording
> Python: Remove ptid from gdb.Record interface
> Python: Introduce gdb.RecordGap class
> Python: Move and rename gdb.BtraceInstruction
> Python: Move and rename gdb.BtraceFunction
> Python: Introduce gdb.Instruction class
>
> gdb/Makefile.in | 2 +
> gdb/btrace.c | 8 +-
> gdb/doc/python.texi | 108 ++--
> gdb/python/py-instruction.c | 67 +++
> gdb/python/py-instruction.h | 30 +
> gdb/python/py-record-btrace.c | 618 ++++++++-------------
> gdb/python/py-record-btrace.h | 42 ++
> gdb/python/py-record.c | 424 +++++++++++++-
> gdb/python/py-record.h | 74 +++
> gdb/python/python-internal.h | 2 +
> gdb/python/python.c | 1 +
> .../gdb.python/py-record-btrace-threads.c | 58 ++
> .../gdb.python/py-record-btrace-threads.exp | 81 +++
> gdb/testsuite/gdb.python/py-record-btrace.exp | 6 +-
> 14 files changed, 1058 insertions(+), 463 deletions(-)
> create mode 100644 gdb/python/py-instruction.c
> create mode 100644 gdb/python/py-instruction.h
> create mode 100644 gdb/python/py-record.h
> create mode 100644 gdb/testsuite/gdb.python/py-record-btrace-threads.c
> create mode 100644 gdb/testsuite/gdb.python/py-record-btrace-threads.exp
OK for the documentation stuff.
Thanks.