This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 2/2] doc: Improve documentation about MI thread output
- From: Simon Marchi <simon dot marchi at ericsson dot com>
- To: Eli Zaretskii <eliz at gnu dot org>
- Cc: <gdb-patches at sourceware dot org>
- Date: Wed, 12 Apr 2017 15:26:08 -0400
- Subject: Re: [PATCH 2/2] doc: Improve documentation about MI thread output
- Authentication-results: sourceware.org; auth=none
- Authentication-results: sourceware.org; dkim=none (message not signed) header.d=none;sourceware.org; dmarc=none action=none header.from=ericsson.com;
- References: <20170412180610.2565-1-simon.marchi@ericsson.com> <20170412180610.2565-2-simon.marchi@ericsson.com> <83y3v5igdx.fsf@gnu.org>
- Spamdiagnosticmetadata: NSPM
- Spamdiagnosticoutput: 1:99
On 17-04-12 03:18 PM, Eli Zaretskii wrote:
>> From: Simon Marchi <simon.marchi@ericsson.com>
>> CC: Simon Marchi <simon.marchi@ericsson.com>
>> Date: Wed, 12 Apr 2017 14:06:10 -0400
>>
>> I noticed that the documentation on how the info about threads is output
>> in MI is duplicated and not up to date. The duplication is between the
>> "GDB/MI Thread Information" page and the -thread-info result
>> description.
>>
>> I improved the "GDB/MI Thread Information" page a bit and referred to it
>> in the -thread-info doc. This way, the -thread-info doc is more precise
>> (it did not mention the "threads" and "current-thread-id" attributes)
>> and concise.
>
> Thanks. This is okay, with a couple of minor gotchas:
>
>> +@item current-thread-id
>> +The global id of the current selected thread. This field is only present if
> ^^^^^^^
> "currently"
Ok.
>> +there is a selected thread and no @var{thread-id} argument was passed to the
>
> How can there not be a selected thread?
When the currently selected inferior is not running. The obvious case is the initial
state of gdb. But it's also possible to have threads but none is selected, for example
when you add a second inferior and switch to it, while the first inferior is running.
The field is output if inferior_ptid != null_ptid, so maybe there are other situations
I am not aware of where there isn't a current thread.
>> +command..
>
> One extra period at end of sentence.
Ok.
Thanks,
Simon