This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 1/2] Remove dead code and "current" field from MI thread output doc
- From: Eli Zaretskii <eliz at gnu dot org>
- To: Simon Marchi <simon dot marchi at ericsson dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Wed, 12 Apr 2017 22:14:25 +0300
- Subject: Re: [PATCH 1/2] Remove dead code and "current" field from MI thread output doc
- Authentication-results: sourceware.org; auth=none
- References: <20170412180610.2565-1-simon.marchi@ericsson.com>
- Reply-to: Eli Zaretskii <eliz at gnu dot org>
> From: Simon Marchi <simon.marchi@ericsson.com>
> CC: Simon Marchi <simon.marchi@ericsson.com>
> Date: Wed, 12 Apr 2017 14:06:09 -0400
>
> The MI documentation says that -thread-info output contains a "current"
> field in the current thread tuple, with the value "*". Current GDB
> master does not do this, and I couldn't find any GDB version that did.
> I suspect that it was never the case.
>
> The code that would correspond to this in print_thread_info_1 is
> essentially dead code. The calls to uiout->text end up in
> mi_out::do_text, which is empty.
>
> This patch removes the documentation bit and the dead code. This
> "current" field is not necessary, since -thread-info outputs a
> "current-thread-id" field.
>
> gdb/ChangeLog:
>
> * thread.c (print_thread_info_1): Remove dead code.
>
> gdb/doc/ChangeLog:
>
> * gdb.texinfo (GDB/MI Thread Commands): Remove "current" field
> from -thread-info output.
OK for the documentation part.
Thanks.