This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA 04/14] Introduce gdb_dlopen_up
- From: Pedro Alves <palves at redhat dot com>
- To: Tom Tromey <tom at tromey dot com>, gdb-patches at sourceware dot org
- Date: Mon, 10 Apr 2017 10:26:54 +0100
- Subject: Re: [RFA 04/14] Introduce gdb_dlopen_up
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx10.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx10.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=palves at redhat dot com
- Dkim-filter: OpenDKIM Filter v2.11.0 mx1.redhat.com DF56E61B90
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com DF56E61B90
- References: <20170408201208.2672-1-tom@tromey.com> <20170408201208.2672-5-tom@tromey.com>
Hi!
On 04/08/2017 09:11 PM, Tom Tromey wrote:
> This introduces gdb_dlopen_up, a unique_ptr that can close a dlopen'd
> library. All the functions working with dlopen handles are updated to
> use this new type.
>
gdb_dlopen_up would sound to me like something that owns a
pointer to dlopen? Since this is a unique pointer that instead
owns a _handle_ that is returned by dlopen, I'd suggest naming
it dlhandle_up or gdb_dlhandle_up instead.
Thanks,
Pedro Alves