This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [RFA 04/14] Introduce gdb_dlopen_up

From: Simon Marchi <simon dot marchi at polymtl dot ca>
To: Tom Tromey <tom at tromey dot com>
Cc: gdb-patches at sourceware dot org
Date: Sun, 09 Apr 2017 23:13:35 -0400
Subject: Re: [RFA 04/14] Introduce gdb_dlopen_up
Authentication-results: sourceware.org; auth=none
References: <20170408201208.2672-1-tom@tromey.com> <20170408201208.2672-5-tom@tromey.com>

On 2017-04-08 16:11, Tom Tromey wrote:

This introduces gdb_dlopen_up, a unique_ptr that can close a dlopen'd
library.  All the functions working with dlopen handles are updated to
use this new type.

I did not try to build this on Windows.

Well, apparently the build on Windows was broken by the guy that pushedthe ptid patch last week, can you believe it? With that fixed (pushinga the fix in a moment) and your patch, it builds fine with--host=x86_64-w64-mingw32.


Otherwise, LGTM.

Thanks,

Simon

References:
- [RFA 00/14] miscellaneous C++-ificiation
  - From: Tom Tromey
- [RFA 04/14] Introduce gdb_dlopen_up
  - From: Tom Tromey

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]