This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: extract_unsigned_integer API (Re: [PATCH] Remove MAX_REGISTER_SIZE from frame.c)
- From: Pedro Alves <palves at redhat dot com>
- To: Yao Qi <qiyaoltc at gmail dot com>
- Cc: Alan Hayward <Alan dot Hayward at arm dot com>, "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>
- Date: Tue, 4 Apr 2017 12:01:34 +0100
- Subject: Re: extract_unsigned_integer API (Re: [PATCH] Remove MAX_REGISTER_SIZE from frame.c)
- Authentication-results: sourceware.org; auth=none
- References: <E80FFABA-2912-4223-AC55-2F4DE6055F47@arm.com> <86lgspqisk.fsf@gmail.com> <5f2f0cb0-6265-46aa-4ad6-eda5ba817da4@redhat.com> <8660itnzvv.fsf@gmail.com> <93774758-0354-c67b-9733-005b3d56fbfa@redhat.com> <2427e9d3-4d91-7d63-a8e4-36aeb233b86e@redhat.com> <86d1ctlhin.fsf@gmail.com>
On 04/03/2017 02:58 PM, Yao Qi wrote:
>>
>> Though for the particular case of frame_unwind_register, since the
>> frame machinery works with struct value's, inside frame_unwind_register
>> there's going to be a value created already, and that has a contents
>> buffer we could access directly. So e.g.,
>> inside frame_unwind_register_signed, we should be able to use
>> frame_unwind_register_value directly thus avoid the need for the local
>> buffer and copying data.
>
> How is the patch below?
>
Fine with me.
Thanks,
Pedro Alves