This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH v2 2/3] spu: Use ptid from regcache instead of inferior_ptid

From: Simon Marchi <simon dot marchi at polymtl dot ca>
To: Pedro Alves <palves at redhat dot com>
Cc: Simon Marchi <simon dot marchi at ericsson dot com>, gdb-patches at sourceware dot org
Date: Mon, 20 Mar 2017 18:24:49 -0400
Subject: Re: [PATCH v2 2/3] spu: Use ptid from regcache instead of inferior_ptid
Authentication-results: sourceware.org; auth=none
References: <e7dd381e-4a3d-83a2-930b-25758f44f81b@redhat.com> <20170320215147.25887-1-simon.marchi@ericsson.com> <4107c32b-465f-59b8-35b2-3caf0f5085bf@redhat.com>

On 2017-03-20 18:06, Pedro Alves wrote:

On 03/20/2017 09:51 PM, Simon Marchi wrote:

From: Simon Marchi <simon.marchi@polymtl.ca>

New in v2: use scoped_restore to save/restore inferior_ptid.

The implementations of to_fetch_regiters/to_store_registers in the spu


Typo: "regiters".


Oops, fixed.

code use some functions that rely on inferior_ptid.  It's simpler for
now to set/restore inferior_ptid.

	* spu-linux-nat.c (spu_fetch_inferior_registers,
	spu_store_inferior_registers): Use ptid from regcache, set and
	restore inferior_ptid.
	* spu-multiarch.c (spu_fetch_registers, spu_store_registers):
	Likewise.


LGTM.


Thanks, pushed.

Simon

References:
- Re: [PATCH 2/3] spu: Use ptid from regcache instead of inferior_ptid
  - From: Pedro Alves
- [PATCH v2 2/3] spu: Use ptid from regcache instead of inferior_ptid
  - From: Simon Marchi
- Re: [PATCH v2 2/3] spu: Use ptid from regcache instead of inferior_ptid
  - From: Pedro Alves

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]