This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] PR remote/21188: Fix remote serial timeout


On 2017-03-13 21:02, Gareth McMullin wrote:
Thank you, Simon.  I only made the smallest change needed to fix the
problem.  I've attached an updated patch
to replace the timeout_remaining field with a local variable, and
remove the unused current_timeout field.

Thanks for the updated patch. I just gave it a quick look, and it looks good functionally. Just a little formatting issue. The four lines:

  else if (timeout_remaining < 0)
    continue;
  else
    return SERIAL_TIMEOUT;

should have one less indent (shift them two spaces to the left).


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]