This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] PR remote/21188: Fix remote serial timeout
- From: Simon Marchi <simon dot marchi at polymtl dot ca>
- To: Gareth McMullin <gareth at blacksphere dot co dot nz>
- Cc: Simon Marchi <simon dot marchi at ericsson dot com>, gdb-patches at sourceware dot org
- Date: Mon, 13 Mar 2017 21:40:36 -0400
- Subject: Re: [PATCH] PR remote/21188: Fix remote serial timeout
- Authentication-results: sourceware.org; auth=none
- References: <CAL8qUbq2+mJ5OgqTmodR_g4tmQqPGYC_50W4zSBgH9N1Xnje8A@mail.gmail.com> <630aafbb-8684-5aea-0fa1-f0f538b4eb02@ericsson.com> <CAL8qUbp4U+4=0CyBC+mfLAOusr+sL2NPOgqyGqo519x5GPHwpw@mail.gmail.com>
On 2017-03-13 21:02, Gareth McMullin wrote:
Thank you, Simon. I only made the smallest change needed to fix the
problem. I've attached an updated patch
to replace the timeout_remaining field with a local variable, and
remove the unused current_timeout field.
Thanks for the updated patch. I just gave it a quick look, and it looks
good functionally. Just a little formatting issue. The four lines:
else if (timeout_remaining < 0)
continue;
else
return SERIAL_TIMEOUT;
should have one less indent (shift them two spaces to the left).