This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |
Other format: | [Raw text] |
On 02/23/2017 08:54 AM, Pedro Alves wrote:
On 02/23/2017 02:47 PM, Luis Machado wrote:I still think it doesn't make much sense to run these tests if we're not sure gcore will support them.I don't understand what you're saying. We can't be sure up front. The "gcore" that is run is GDB's "gcore" command. If that doesn't work, gdb_gcore_cmd calls unsupported, and the rest of the testcase is skipped.
The point is that we are indeed sure this isn't supported, unless we officially support core files on bare-metal targets (i don't think we do). See below.
They may run a few early tests/setup tests, but that won't translate into meaningful PASSes. But i'm ok keeping it as-is if others think the early test PASSes are useful.Looks like it's been useful to catch a startup code problem. ;-)
Don't you agree this is a clear sign we are really testing something else other than core file support? It just means a proper standalone test doesn't exist to catch such a problem and we got lucky crashing when doing a core file test on a target that doesn't support it. It is not like the test was designed to catch this.
I find it a bit messy. A proper test would attempt to run pie executables to completion (and i can contribute that to verify this particular problem).
I just don't like the concept of running a test that is unsupported on a particular target (core files) only to test a side-effect during pre-test/setup phases. It only adds to artificial PASSes that don't necessarily translate to robustness.
But i understand if this is not acceptable. I just want to clean this target up, and seeing core file tests being executed is just confusing. :-)
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |