Re: [PATCH v3 5/5] btrace, testsuite: fix extended-remote fail

[Pedro Alves <palves at redhat dot com>]

On 01/31/2017 04:06 PM, Metzger, Markus T wrote:

> There's a comment in lib/gdb.exp before gdb_skip_xml_test, which is called
> by skip_gdbserver_tests:
> 
> 	# Return true if a test should be skipped due to lack of XML support
> 	# in the host GDB.
> 	# NOTE: This must be called while gdb is *not* running.
> 
> 	gdb_caching_proc gdb_skip_xml_test {


Ah, that starts gdb itself, runs "set tdesc filename" and then
exits gdb.  Indeed, that can't work in the middle of some
other test...  A command without side effects ("maint check-supports-xml"
or something), would avoid this...  But let's not bother.

> I thought this is supposed to be general knowledge so I didn't bother to go into more
> detail in the commit message.

I don't recall ever noticing this before.

> Looks like we don't need the return, though.  And the check should
> probably go into skip_xml_tests.  Let me add a separate patch for this.

Thanks!

-- 
Pedro Alves