This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v3] Fix PTRACE_GETREGSET failure for compat inferiors on arm64
- From: Kees Cook <keescook at chromium dot org>
- To: Yao Qi <qiyaoltc at gmail dot com>
- Cc: "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>, Doug Evans <dje at google dot com>, Brian Murray <brian dot murray at canonical dot com>, Matthias Klose <matthias dot klose at canonical dot com>
- Date: Thu, 26 Jan 2017 15:37:04 -0800
- Subject: Re: [PATCH v3] Fix PTRACE_GETREGSET failure for compat inferiors on arm64
- Authentication-results: sourceware.org; auth=none
- References: <20170119210015.GA87383@beast> <CAH=s-PNgbtTayMYYNYgKK1kUJoS4tT_WS88EUB+EYYGEkf24qQ@mail.gmail.com>
On Thu, Jan 26, 2017 at 3:23 PM, Yao Qi <qiyaoltc@gmail.com> wrote:
> On Thu, Jan 19, 2017 at 9:00 PM, Kees Cook <keescook@chromium.org> wrote:
>>
>
> The patch is good to me, some nits below,
>
>> gdb/ChangeLog:
>>
>> 2016-12-19 Kees Cook <keescook@google.com>
>>
>> * gdb/arm-linux-nat.c: Skip soft-float registers when using hard-float.
>
> * gdb/arm-linux-nat.c (arm_linux_fetch_inferior_registers): Call fetch_fpregs
> if target has fpa registers.
> (arm_linux_store_inferior_registers): Call store_fpregs if target has
> fpa registers.
Ah-ha, thanks!
>
>> }
>> - else
>> + else
>> {
>
> Unnecessary change. I'll push your patch in tomorrow.
Okay, I wasn't sure if whitespace/code-style fixes should be merged as
they were found.
Thanks!
-Kees
--
Kees Cook
Nexus Security