This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Fix uppercase test names in gdb.python/py-xmethods.exp


On 01/20/2017 09:34 AM, Pedro Alves wrote:
On 01/20/2017 03:30 PM, Luis Machado wrote:


How about the following?


 # Skip all tests if Python scripting is not enabled.
-if { [skip_python_tests] } { continue }
+if { [skip_python_tests] } {
+    untested "skipping Python tests"
+    return
+}


There's an "unsupported" call inside skip_python_tests.

Hmm, i was working under the assumption this was a flag. In this case it would make sense to handle all of these checks in the same way and not add untested calls, making everything standard.

I can work on that, but should we drop adding any untested calls in this particular patch and only return (until a follow on patch)?


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]