This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 3/8] Disassembly unit test: disassemble one instruction


On 01/12/2017 03:15 PM, Pedro Alves wrote:
> Putting it all together, you'd have something like:
> 
>     explicit gdb_disassembler_test (struct gdbarch *gdbarch,
> 			            struct ui_file *stream,

                                    ^^^^^^^^^^^^^^^^^^^^^^

This stream parameter here shouldn't exist, of course.  It's just
that my Thunderbird hasn't learned to flag coding problems yet.  :-)

> 				    const gdb_byte *insn)
>       : gdb_disassembler (gdbarch, 
>                           (DISASSEMBLER_TEST_VERBOSE
>                            ? gdb_stdout : null_stream ()),
> 			  gdb_disassembler_test::read_memory),
> 	m_insn (insn)
>     {}


-- 
Thanks,
Pedro Alves


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]