This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA 7/8] Use unique_xmalloc_ptr in execute_gdb_command


On 12/23/2016 08:00 PM, Tom Tromey wrote:
> Pedro> In some other local patch that I hadn't posted, I handled a similar
> Pedro> situation of save/restoring some global that we don't want to expose
> Pedro> by making the "make_cleanup_..." function return a scoped_restore, which
> Pedro> avoids having to create a new class.  It seems a bit simpler that
> Pedro> creating a class to me, and maybe a tiny bit more efficient code-space
> Pedro> wise (rtti?)  Did you consider this approach?
> 
> Tom> I didn't, but I like it, so I'll make this change.
> 
> Here's the new version of this patch.

OK.

Thanks,
Pedro Alves


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]