This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Fix type of expr in info_mach_region_command (fixes OSX build)
- From: Pedro Alves <palves at redhat dot com>
- To: Manish Goregaokar <manish at mozilla dot com>, gdb-patches at sourceware dot org
- Date: Fri, 16 Dec 2016 11:36:47 +0000
- Subject: Re: [PATCH] Fix type of expr in info_mach_region_command (fixes OSX build)
- Authentication-results: sourceware.org; auth=none
- References: <CAFOnWk=gqxPJJy-CSgpEW3xn6vJ=Z2NU+ax9UY2tDoDYyXqgHQ@mail.gmail.com>
On 12/15/2016 08:17 PM, Manish Goregaokar wrote:
> gdb wasn't building on OSX. Colleague fixed it.
>
> error was
>
> darwin-nat-info.c:733:8: error: assigning to 'struct expression *'
> from incompatible type 'expression_up' (aka
> 'std::__1::unique_ptr<expression, gdb::xfree_deleter<expression> >')
> expr = parse_expression (exp);
> ^ ~~~~~~~~~~~~~~~~~~~~~~
>
Oh, I just approved Bernhard's patch without noticing this one,
sorry about that:
https://sourceware.org/ml/gdb-patches/2016-12/msg00318.html
I prefer his version for moving the declaration, but any
is fine...
Thanks,
Pedro Alves