This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 1/8] AARCH64 SVE: Increse max register sizes
- From: Yao Qi <qiyaoltc at gmail dot com>
- To: Alan Hayward <alan dot hayward at arm dot com>
- Cc: "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>
- Date: Tue, 13 Dec 2016 11:47:42 +0000
- Subject: Re: [PATCH 1/8] AARCH64 SVE: Increse max register sizes
- Authentication-results: sourceware.org; auth=none
- References: <D46B0D70.154DB%alan.hayward@arm.com> <20161212181032.GC25542@E107787-LIN> <D4757157.1649A%alan.hayward@arm.com>
On 16-12-13 10:05:49, Alan Hayward wrote:
> I’ve just noticed I forgot to add a changelog for all of my patches.
> Apologies - I’ll add them for any V2 versions (or happy to repost all of
> them again with changelogs if required).
ChangeLog is not needed for V1.
>
> On 12/12/2016 18:10, "Yao Qi" <qiyaoltc@gmail.com> wrote:
>
> >On 16-12-05 12:26:24, Alan Hayward wrote:
> >> This is part of a series adding AARCH64 SVE support to gdb and
> >>gdbserver.
> >>
> >> In SVE the maximum size of a variable-length vector register is 256
> >>bytes,
> >> four
> >> times the current maximum size currently supported in gdb. This patch
> >> increases
> >> the max register size and max gdbserver buffer size accordingly.
> >
> >Joel expressed the willingness that we should make MAX_REGISTER_SIZE
> >gdbarch specific last time when it was changed from 32 to 64.
> >https://sourceware.org/ml/gdb-patches/2010-09/msg00245.html
> >I think we should make MAX_REGISTER_SIZE gdbarch specific, or stop
> >using it at all.
>
> I’m happy to do this if that’s what people want. I avoided doing it
> because I
> didn’t want to subtly break something and it’s going to be quite a large
> change -
> I might submit it a set of patches by itself.
>
You can start from changing amd64-tdep.c and frame.c, which are
interesting to most of people here. It shouldn't take long to finish
the patch, and post it to get feedback quickly. If people agree/like
the change, then you can move on changing the rest in the same way.
--
Yao (齐尧)