Re: [PATCH] Read corrrect auxiliary entry in AIX.

["Sangamesh Mallayya" <sangamesh dot swamy at in dot ibm dot com>]

"Ulrich Weigand" <uweigand@de.ibm.com> wrote on 11/25/2016 05:14:16 PM:

> From: "Ulrich Weigand" <uweigand@de.ibm.com>
> To: Sangamesh Mallayya/India/IBM@IBMIN
> Cc: gdb-patches@sourceware.org, Ulrich.Weigand@de.ibm.com (Ulrich 
Weigand)
> Date: 11/25/2016 05:14 PM
> Subject: Re: [PATCH] Read corrrect auxiliary entry in AIX.
> 
> Sangamesh Mallayya wrote:
> 
> > Yes, all other switch inside XTY_LD are just doing continue.
> > But thought we just keep it for reference so that it is just a 
indication
> > of XTY_LD case.
> 
> Hmm, OK.   I guess it's fine to leave it.  But then please keep the
> XMC_PR switch case as well and add a comment that these have already 
been
> processed via the ISFCN check above.
> 
> > Are else do you thing making them "#if 0" would be better or should we
> > remove it completely ?
> > 
> > I will do one more round of test and make sure we don't see any new
> > failures with new change.

Thanks for the suggestion.

Please find the updated patch attached.
Please find the summary of test cases pasted at the end. I don't see any 
new failures with the fix.

One more point i want to mention is, test cases we ran is with the old 
repository which we cloned around 1 month back.
With freshly cloned repository we are facing compilation errors even 
without applying our current changes.
We are thinking it could be due to our environment issue or the version of 
gcc which we are using.
Do you want us to run the test with latest branch and send you the result 
once that is done after fixing compilation issue. ?

gcc with no -ffunction-sections
===============================

Without patch
-------------
# of expected passes            9872
# of unexpected failures        1613
# of expected failures          14
# of unresolved testcases       1
# of untested testcases         60
# of unsupported tests          30

with patch
----------
# of expected passes            9874
# of unexpected failures        1611
# of expected failures          14
# of unresolved testcases       1
# of untested testcases         60
# of unsupported tests          30

gcc with -ffunction-sections
============================

Without patch
-------------
# of expected passes            8608
# of unexpected failures        3082
# of unexpected successes       1
# of expected failures          14
# of unresolved testcases       4
# of untested testcases         60
# of unsupported tests          30

with patch
----------
# of expected passes            8610
# of unexpected failures        3080
# of unexpected successes       1
# of expected failures          14
# of unresolved testcases       4
# of untested testcases         60
# of unsupported tests          30

xlc with no -qfuncsect
======================

Without patch
-------------
# of expected passes            9013
# of unexpected failures        1958
# of expected failures          13
# of unresolved testcases       3
# of untested testcases         71
# of unsupported tests          31

with patch
----------
# of expected passes            9013
# of unexpected failures        1958
# of expected failures          13
# of unresolved testcases       3
# of untested testcases         71
# of unsupported tests          31



xlc with -qfuncsect
===================

Without patch
-------------
# of expected passes            2798
# of unexpected failures        2718
# of expected failures          10
# of unresolved testcases       74
# of untested testcases         92
# of unsupported tests          15

with patch
----------
# of expected passes            7559
# of unexpected failures        3415
# of unexpected successes       1
# of expected failures          13
# of unresolved testcases       9
# of untested testcases         71
# of unsupported tests          29

Attachment: read_xcoff_aux.patch
Description: Binary data

Attachment: ChangeLog
Description: Binary data