Re: [PATCH] Bug 20936 - provide sparc and sparcv9 target description XML files

[Yao Qi <qiyaoltc at gmail dot com>]

On 16-12-06 11:40:42, Ivo Raisr wrote:
> Please find attached a patch which fixes PR tdep/20936.
> 
> This patch provides sparc (32-bit) and sparcv9 (64-bit) target
> description XML files.
> Files sparc{64}-cp0.xml, sparc{64}-cpu.xml and sparc{64}-fpu.xml are
> OS independent.
> Files sparc-solaris.xml and sparc64-solaris.xml are specific to Solaris.

Hi Ivo,
Could you add a new directory "sparc" in gdb/features/ and put all
.xml files there?

> 
> gdb regression test suite was run successfully on Solaris/sparc.
> 
> This PR with a patch is used as a foundation for another patch which
> will enhance sparc{64}-tdep
> with the ability to work the Valgrind shadow registers. Stay tuned.
> 

I suppose your next patch is to change sparc{64}-tdep.c to use these
target descriptions.  I'd like to get target description definition
and use in a single patch.  You add some thing new in this patch,
but it is not used at all.

All these new added features should be documented
https://sourceware.org/gdb/current/onlinedocs/gdb/Standard-Target-Features.html

> 
> ChangeLog entry:
> 2016-12-06  Ivo Raisr  <ivo.raisr@oracle.com>
> 
>     PR tdep/20936
>     Provide sparc and sparcv9 target description XML files.

Indented by tab rather than spaces.

>     * sparc-cp0.xml, sparc-cpu.xml, sparc-fpu.xml: New files for
>     sparc 32-bit.
>     * sparc64-cp0.xml, sparc64-cpu.xml, sparc64-fpu.xml: New files
>     for sparc 64-bit.
>     * sparc-solaris.xml, sparc64-solaris.xml, sparc-solaris.c,
>     sparc64-solaris.c: New files for sparc and sparc64 on Solaris.

	* sparc-solaris.c, sparc64-solaris.c: Generated.

> diff -Npur a/gdb/features/sparc-cp0.xml b/gdb/features/sparc-cp0.xml
> --- a/gdb/features/sparc-cp0.xml	1969-12-31 16:00:00.000000000 +0000
> +++ b/gdb/features/sparc-cp0.xml	2016-12-06 03:07:35.249368327 +0000
> @@ -0,0 +1,19 @@
> +<?xml version="1.0"?>
> +<!-- Copyright (C) 2013-2016 Free Software Foundation, Inc.
> +
> +     Copying and distribution of this file, with or without modification,
> +     are permitted in any medium without royalty provided the copyright
> +     notice and this notice are preserved.  -->
> +
> +<!DOCTYPE feature SYSTEM "gdb-target.dtd">
> +<feature name="org.gnu.gdb.sparc.cp0">
> +  <reg name="y" bitsize="32" type="uint32" regnum="64"/>
> +  <reg name="psr" bitsize="32" type="uint32" regnum="65"/>
> +  <reg name="wim" bitsize="32" type="uint32" regnum="66"/>
> +  <reg name="tbr" bitsize="32" type="uint32" regnum="67"/>
> +  <reg name="pc" bitsize="32" type="uint32" regnum="68"/>
> +  <reg name="npc" bitsize="32" type="uint32" regnum="69"/>

I suspect the type should be code_ptr.

> +  <reg name="fsr" bitsize="32" type="uint32" regnum="70"/>
> +  <reg name="csr" bitsize="32" type="uint32" regnum="71"/>
> +</feature>
> +

-- 
Yao (齐尧)