This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] fix for aarch64 sim tbnz bug
- From: Nick Clifton <nickc at redhat dot com>
- To: Jim Wilson <jim dot wilson at linaro dot org>, gdb-patches at sourceware dot org
- Date: Fri, 2 Dec 2016 12:03:11 +0000
- Subject: Re: [PATCH] fix for aarch64 sim tbnz bug
- Authentication-results: sourceware.org; auth=none
- References: <CABXYE2W++FWtcyNq4FAroJ2+VNJOHWs7-sdHMBm=6kOwSkD5Ug@mail.gmail.com>
Hi Jim,
> Tested with a gcc C testsuite run. This reduces failures from 2856 to 2710.
Patch approved - please apply.
Just one question:
+ if (aarch64_get_reg_u64 (cpu, rt, NO_SP) & (((uint64_t) 1) << pos))
Would:
+ if (aarch64_get_reg_u64 (cpu, rt, NO_SP) & (1UL << pos))
work as well, or would this break on 32-bit hosts ?
Cheers
Nick