This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA] PR symtab/16264 - support DW_AT_main_subprogram


On 11/18/2016 02:48 PM, Tom Tromey wrote:

>>> +if {[gdb_start_cmd] < 0} {
>>> +    untested ${testfile}
> 
> Luis> untested "Failed to stop at mymain"?
> 
> I used "Could not start ${testfile}".
> 
> Luis> Similarly:
> Luis> gdb_test "" "Temporary breakpoint .* mymain.*" "Stopped at mymain"
> Luis> Otherwise looks good to me.
> 
> I changed this.

Please use lowercase "could" and "stopped", though.

OK with that change.

Thanks,
Pedro Alves


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]