This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 22/22] Introduce enum_flag type for ui_out flags

On 11/24/2016 03:32 PM, Simon Marchi wrote:
> This patch changes the ui_out flags to be an enum flag.

OK.

>  
>  /* flags enum */
> -enum ui_flags
> +enum ui_out_flag
>    {
> -    ui_from_tty = 1,
>      ui_source_list = 2
>    };
>  
> +DEF_ENUM_FLAGS_TYPE (ui_out_flag, ui_out_flags);

Please add an "#include common/enum-flags.h", so the file
includes what it needs instead of relying on indirect includes.

Thanks,
Pedro Alves
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]