This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 1/2] Add unit test to aarch64 prologue analyzer
- From: Antoine Tremblay <antoine dot tremblay at ericsson dot com>
- To: Yao Qi <qiyaoltc at gmail dot com>
- Cc: <gdb-patches at sourceware dot org>
- Date: Tue, 29 Nov 2016 09:57:46 -0500
- Subject: Re: [PATCH 1/2] Add unit test to aarch64 prologue analyzer
- Authentication-results: sourceware.org; auth=none
- Authentication-results: spf=none (sender IP is ) smtp.mailfrom=antoine dot tremblay at ericsson dot com;
- References: <1480428758-2481-1-git-send-email-yao.qi@linaro.org>
- Spamdiagnosticmetadata: NSPM
- Spamdiagnosticoutput: 1:99
Yao Qi writes:
> @@ -436,6 +461,89 @@ aarch64_analyze_prologue (struct gdbarch *gdbarch,
> return start;
> }
>
> +static CORE_ADDR
> +aarch64_analyze_prologue (struct gdbarch *gdbarch,
> + CORE_ADDR start, CORE_ADDR limit,
> + struct aarch64_prologue_cache *cache)
> +{
> + instruction_reader reader { };
> +
Could we use the default constructor here? If it's kept.
> + return aarch64_analyze_prologue (gdbarch, start, limit, cache,
> + reader);
> +}
> +
> +#if GDB_SELF_TEST
> +
> +namespace selftests {
> +
> + /* Instruction reader from manually cooked instruction sequences. */
> + class instruction_reader_test : public abstract_instruction_reader
> + {
> + public:
> + instruction_reader_test() = default ;
Very nit, but there's a space before ';'
Also I wonder if we need to specify the default constructor explicitly ?
Is there a rationale for it?
It's never used too, unless you apply my previous comment.