This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 3/3] Restrict checking value.lval on using address
On Fri, Nov 25, 2016 at 12:52:10PM +0100, Ulrich Weigand wrote:
> Yao Qi wrote:
>
> > * ada-lang.c (ensure_lval): Call set_value_address after setting
> > VALUE_LVAL.
> > * elfread.c (elf_gnu_ifunc_resolve_addr): Set VALUE_LVAL to
> > lval_memory.
> > (elf_gnu_ifunc_resolver_return_stop): Likewise.
> > * value.c (value_fn_field): Likewise.
> > (value_from_contents_and_address_unresolved): Likewise.
> > (value_from_contents_and_address): Likewise.
> > (value_address): Check value->lval isn't
> > lval_memory.
> > (value_raw_address): Likewise.
> > (set_value_address): Assert value->lval is lval_memory.
>
> Looks good to me.
>
Patch is pushed in.
--
Yao (齐尧)