This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH v2 1/4] gdb: Add tdesc_find_register functions


On 27 Nov 2016 15:16, Stafford Horne wrote:
> +/* Search FEATURE for a register REGNO and return its name. */

GNU style puts two spaces after periods

> +char *
> +tdesc_find_register_name (const struct tdesc_feature *feature,
> +			   int regno)
> +char *
> +tdesc_find_register_group_name (const struct tdesc_feature *feature,
> +			   int regno)

seems like return values for both of these should be const
-mike

Attachment: signature.asc
Description: Digital signature


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]