This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 1/8] Fixup testcases outputting own name as a test name


On 11/25/2016 05:08 PM, Luis Machado wrote:

> diff --git a/gdb/testsuite/gdb.base/charset.exp b/gdb/testsuite/gdb.base/charset.exp
> index 44d5502..eb9b37a 100644
> --- a/gdb/testsuite/gdb.base/charset.exp
> +++ b/gdb/testsuite/gdb.base/charset.exp
> @@ -146,7 +146,7 @@ gdb_expect {
>  # sets: "auto" and the default.  In this situation, this set of tests
>  # is pointless.
>  if {[llength [array names charsets]] < 3} {
> -    untested charset.exp
> +    untested "less than 3 charsets"

"fewer than"

/me runs.

> +    untested "couldn't compile ${srcfile} to ${binfile}"

I think all these references to $binfile will put the full file
path on gdb.sum?  I think you want $testfile instead.

Thanks,
Pedro Alves


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]