This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] gdb/tracepoint.c: Don't use printf_vma
- From: Pedro Alves <palves at redhat dot com>
- To: gdb-patches at sourceware dot org
- Date: Thu, 17 Nov 2016 00:46:55 +0000
- Subject: Re: [PATCH] gdb/tracepoint.c: Don't use printf_vma
- Authentication-results: sourceware.org; auth=none
- References: <1479251441-16443-1-git-send-email-palves@redhat.com>
On 11/15/2016 11:10 PM, Pedro Alves wrote:
> I noticed that bfd's printf_vma prints to stdout directly:
>
> bfd-in2.h:202:#define printf_vma(x) fprintf_vma(stdout,x)
>
> This is a bad idea in gdb, where we should use
> gdb_stdout/gdb_stderr/gdb_stdlog, etc., to support redirection.
>
> Eliminate uses of sprintf_vma too while at it.
>
> Tested on Fedora 23, w/ gdbserver.
>
> gdb/ChangeLog:
> yyyy-mm-dd Pedro Alves <palves@redhat.com>
>
> * tracepoint.c (collection_list::add_memrange): Add gdbarch
> parameter. Use paddress instead of printf_vma. Adjust recursive
> calls.
> (collection_list::stringify): Use paddress and phex_nz instead of
> sprintf_vma. Adjust add_memrange call.
> * tracepoint.h (collection_list::add_memrange): Declare new method.
Now pushed.
Thanks,
Pedro Alves