This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH v2 4/5] Make gdb.PendingFrame.read_register handle "user" registers


On Wed, 2 Nov 2016 15:23:32 -0700
Kevin Buettner <kevin@buettner.to> wrote:

> [ FYI, Pedro has already OK'd this one.  It's unchanged from the version
>   in the earlier series, but is included here for completeness. ]
> 
> The C function, pending_framepy_read_register(), which implements
> the python interface gdb.PendingFrame.read_register does not handle
> the so called "user" registers like "pc".  An assertion error is
> triggered due to the user registers having numbers larger than or
> equal to gdbarch_num_regs(gdbarch).
> 
> With the VALUE_FRAME_ID tweak in place, the call to
> get_frame_register_value() can simply be replaced by a call to
> value_of_register(), which handles both real registers as well as the
> user registers.
> 
> gdb/ChangeLog:
>     
>     	* python/py-unwind.c (pending_framepy_read_register): Use
>     	value_of_register() instead of get_frame_register_value().

I've pushed this change.

Kevin


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]