This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v2 3/5] Distinguish sentinel frame from null frame
On Wed, 9 Nov 2016 14:48:09 +0000
Pedro Alves <palves@redhat.com> wrote:
> On 11/02/2016 10:16 PM, Kevin Buettner wrote:
>
> > --- a/gdb/frame.h
> > +++ b/gdb/frame.h
> > @@ -90,6 +90,9 @@ enum frame_id_stack_status
> > /* Stack address is valid, and is found in the stack_addr field. */
> > FID_STACK_VALID = 1,
> >
> > + /* Sentinel frame. Stack may or may not be valid. */
> > + FID_STACK_SENTINEL = 2,
>
> What does this "Stack may or may not be valid" comment mean?
> "sentinel_frame_id" is a constant, how can the "stack_addr" field
> vary?
I've adjusted the comment as follows:
+ /* Sentinel frame. */
+ FID_STACK_SENTINEL = 2,
> Otherwise LGTM.
Pushed.
Thanks for the review.
Kevin