This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [RFA 11/11] Change python_run_simple_file to use gdbpy_ref

From: Tom Tromey <tom at tromey dot com>
To: Pedro Alves <palves at redhat dot com>
Cc: Tom Tromey <tom at tromey dot com>, gdb-patches at sourceware dot org
Date: Wed, 16 Nov 2016 11:22:15 -0700
Subject: Re: [RFA 11/11] Change python_run_simple_file to use gdbpy_ref
Authentication-results: sourceware.org; auth=none
References: <1478986125-15122-1-git-send-email-tom@tromey.com> <1478986125-15122-12-git-send-email-tom@tromey.com> <871sygidik.fsf@tromey.com> <274d1efb-9bbf-7d22-1053-0a5ff99ca715@redhat.com>

>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:

Pedro> Actually, you don't really need that -- that WIN32 code should work
Pedro> on Unix as well, it's just not as efficient as the other branch.
Pedro> So you can just hack/invert the #ifndef _WIN32 locally for testing.

What if I just remove the non-win32 code here?
It might be slightly less efficient, but only slightly; with the upside
being that we'd have just a single code path to test.

Tom

Follow-Ups:
- Re: [RFA 11/11] Change python_run_simple_file to use gdbpy_ref
  - From: Pedro Alves
- Re: [RFA 11/11] Change python_run_simple_file to use gdbpy_ref
  - From: Tom Tromey

References:
- [RFA 00/11] third series of C++ use in Python layer
  - From: Tom Tromey
- [RFA 11/11] Change python_run_simple_file to use gdbpy_ref
  - From: Tom Tromey
- Re: [RFA 11/11] Change python_run_simple_file to use gdbpy_ref
  - From: Tom Tromey
- Re: [RFA 11/11] Change python_run_simple_file to use gdbpy_ref
  - From: Pedro Alves

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]