Now the the variable set-hook mechanism supports automatic rollback of
the variable value if the set-hook throws an error, simplify existing
cases where we manually performed roll-back within the set-hook.
gdb/ChangeLog:
* dcache.c (set_dcache_size): Don't change value on error path.
(set_dcache_line_size): Likewise.
* record.c (record_insn_history_size_setshow_var): Remove.
(record_call_history_size_setshow_var): Remove.
(validate_history_size): Simplify to just the error check.
(set_record_insn_history_size): Update call to
validate_history_size.
(set_record_call_history_size): Likewise.
(_initialize_record): Remove use of *_setshow_var.
* symtab.c (new_symbol_cache_size): Remove.
(symbol_cache_size): Update comment.
(set_symbol_cache_size_handler): Simplify error check.
(_initialize_symtab): Remove use of new_symbol_cache_size.
* valprint.c (input_radix_1): Remove.
(set_input_radix): Remove use of input_radix_1.
(set_input_radix_1): Likewise.
(output_radix_1): Remove.
(set_output_radix): Remove use of output_radix_1.
(set_output_radix_1): Likewise.
(_initialize_valprint): Remove use of output_radix_1 and
input_radix_1.
* value.c (set_max_value_size): Simplify error case.
gdb/testsuite/ChangeLog:
* gdb.base/max-value-size.exp: Update expected output.
---
gdb/ChangeLog | 25 +++++++++++++++++++
gdb/dcache.c | 12 +++------
gdb/record.c | 41 ++++++-------------------------
gdb/symtab.c | 23 ++++-------------
gdb/testsuite/ChangeLog | 4 +++
gdb/testsuite/gdb.base/max-value-size.exp | 4 +--
gdb/valprint.c | 31 ++++++-----------------
gdb/value.c | 6 +----
8 files changed, 56 insertions(+), 90 deletions(-)