This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH v2 8/8] Add documentation for new instruction record Python bindings.

From: Eli Zaretskii <eliz at gnu dot org>
To: Tim Wiederhake <tim dot wiederhake at intel dot com>
Cc: gdb-patches at sourceware dot org, palves at redhat dot com, markus dot t dot metzger at intel dot com
Date: Fri, 04 Nov 2016 10:15:56 +0200
Subject: Re: [PATCH v2 8/8] Add documentation for new instruction record Python bindings.
Authentication-results: sourceware.org; auth=none
References: <1478246074-14526-1-git-send-email-tim.wiederhake@intel.com> <1478246074-14526-9-git-send-email-tim.wiederhake@intel.com>
Reply-to: Eli Zaretskii <eliz at gnu dot org>

> From: Tim Wiederhake <tim.wiederhake@intel.com>
> Cc: palves@redhat.com, markus.t.metzger@intel.com
> Date: Fri,  4 Nov 2016 08:54:34 +0100
> 
> gdb/doc/ChangeLog:
> 
> 	* python.texi: Add record Python bindings entry.

This log entry should mention the node name.

> +@defvar Record.method
> +A string with the current recording method, e.g. @code{full} or

Please follow "e.g." either by a comma or by @:, so that it wouldn't
be taken as an end of the sentence.

Otherwise, the documentation part of this patch series is okay.

Thanks.

References:
- [PATCH v2 0/8] Python bindings for btrace recordings
  - From: Tim Wiederhake
- [PATCH v2 8/8] Add documentation for new instruction record Python bindings.
  - From: Tim Wiederhake

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]