This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 1/3] Remove single-step breakpoint for GDBserver internal event
- From: Pedro Alves <palves at redhat dot com>
- To: Yao Qi <qiyaoltc at gmail dot com>
- Cc: "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>
- Date: Thu, 27 Oct 2016 14:16:53 +0100
- Subject: Re: [PATCH 1/3] Remove single-step breakpoint for GDBserver internal event
- Authentication-results: sourceware.org; auth=none
- References: <1474856716-5913-1-git-send-email-yao.qi@linaro.org> <1474856716-5913-2-git-send-email-yao.qi@linaro.org> <e353d2fb-8077-c8ef-3d57-0c5e063ee015@redhat.com> <CAH=s-PPOdSfxKGuHd3QagxOvGheiq+MiR7z28ZRiZj_tv62cgA@mail.gmail.com>
On 10/26/2016 09:14 PM, Yao Qi wrote:
> On Wed, Oct 26, 2016 at 1:45 PM, Pedro Alves <palves@redhat.com> wrote:
>> On 09/26/2016 03:25 AM, Yao Qi wrote:
>>> This patch removes single-step breakpoints if the event is only
>>> GDBserver internal, IOW, isn't reported back to GDB.
>>
>> Can you expand on rationale? Why does being internal matter?
>
> We remove single-step breakpoints on the moment we report event
> back to GDB. However, if we use single-step breakpoints and get
> some events, we don't report them back to GDB and keep controlling
> the inferior, we need to remove single-step breakpoints. For
> example, in range stepping, until the program goes out of the range,
> we keep doing single step (by software), in a loop of insert single-step
> breakpoints, resume, remove them.
>
Ah yes, sorry, I should have read the code in more detail.
I agree, totally makes sense to do this here.
Thanks,
Pedro Alves