Re: [PATCH] New function value_has_address

[Simon Marchi <simon dot marchi at polymtl dot ca>]

That help clarifies the code, I like it.

> diff --git a/gdb/value.c b/gdb/value.c
> index b825aec..4b5cbde 100644
> --- a/gdb/value.c
> +++ b/gdb/value.c
> @@ -1538,12 +1538,20 @@ value_lval_const (const struct value *value)
>    return value->lval;
>  }
>
> +/* Return true if VALUE has address, otherwise return false.  */

This comment is really obvious, it's really just stating the function 
name.  Could you expand it a bit, perhaps saying what it means for a 
value to "have address"?  I suppose it means that it has a memory 
address on the target?