This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: GDB AIX build broken

On 10/25/2016 01:13 AM, David Edelsohn wrote:
> On Mon, Oct 24, 2016 at 7:00 PM, Pedro Alves <palves@redhat.com> wrote:
> 
>> That's a hint, but it can't be the fix.  common-defs.h must be the
>> first file included.  I suspect that gnulib's inttypes.h
>> replacement logic is broken on AIX.
> 
> The gnulib import definitely is the commit that caused the breakage.
> 
> Interestingly,
> 
> gdb/btrace.c uses
> 
> #include <inttypes.h>
> 
> while
> 
> gdb/common/buffer.c uses
> 
> #include "inttypes.h"

I can't imagine there being a real reason for that.

> 
> Also, I'm sorry if my earlier comments came across poorly.

Sorry if I misunderstood them.  Might have been lost in translation.

Thanks,
Pedro Alves
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]