This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [RFA v2 15/17] Convert DWARF expr functions to methods

From: Pedro Alves <palves at redhat dot com>
To: Tom Tromey <tom at tromey dot com>
Cc: gdb-patches at sourceware dot org
Date: Thu, 20 Oct 2016 23:01:28 +0100
Subject: Re: [RFA v2 15/17] Convert DWARF expr functions to methods
Authentication-results: sourceware.org; auth=none
References: <1476393012-29987-1-git-send-email-tom@tromey.com> <1476393012-29987-16-git-send-email-tom@tromey.com> <77fe3ede-66ea-93a3-eb9f-50f9c22a06e4@redhat.com> <87lgxihewg.fsf@tromey.com>

On 10/20/2016 10:46 PM, Tom Tromey wrote:
>>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:
> 
> Pedro> I notice that several of the intro comments to functions that 
> Pedro> are now methods still talk about CTX.  Should they be
> Pedro> tweaked?  Maybe to "to this context's stack".  Or maybe they're clear
> Pedro> as is anyway.
> 
> I've updated this patch as appended.

LGTM.

Thanks,
Pedro Alves

References:
- [RFA v2 00/17] more C++
  - From: Tom Tromey
- [RFA v2 15/17] Convert DWARF expr functions to methods
  - From: Tom Tromey
- Re: [RFA v2 15/17] Convert DWARF expr functions to methods
  - From: Pedro Alves
- Re: [RFA v2 15/17] Convert DWARF expr functions to methods
  - From: Tom Tromey

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]