This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA v2 06/17] Record minimal symbols directly in reader.
>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:
>> +minimal_symbol_reader::record_full (const char *name, int name_len,
>> + int copy_name,
Pedro> Can you make this bool while at it?
I've added a follow-up patch for this.
>> + SECTION - the symbol's section
>> + appropriate obj_section for the minimal symbol. This can be NULL.
Pedro> Hmm, preexisting, but, this parameter's type is actually int.
Pedro> Not sure that comment makes sense as is.
I fixed this.
>> + OBJFILE - the objfile associated with the minimal symbol. */
Pedro> ENOSUCHPARAMETER.
.. and this
>> +
>> + struct minimal_symbol *record_full (const char *name,
>> + int name_len,
>> + int copy_name,
Pedro> Use "bool" for copy_name ?
.. and this and the other related things in the follow-up.
Also I've fixed the other callers of record_full.
Tom