This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA v2 13/17] Some cleanup removal in dwarf2loc.c


On 10/13/2016 10:10 PM, Tom Tromey wrote:
> This removes some cleanups and manual allocation handling in
> dwarf2loc.c with std::vector.  Note that this patch has a case where
> the vector would normally fall into the "use gdb::unique_ptr"
> guidelines -- but here because the vector is immediately initialized,
> I moved the initialization into the constructor call, for further
> code savings.

Makes sense.  LGTM.

Thanks,
Pedro Alves


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]