Re: [RFA v2 02/17] Use scoped_restore for ui_file

[Pedro Alves <palves at redhat dot com>]

This is OK.  Please push.

On 10/13/2016 10:09 PM, Tom Tromey wrote:
> +  scoped_restore save_stdout = make_scoped_restore (&gdb_stdout, str_file);
> +  scoped_restore save_stderr = make_scoped_restore (&gdb_stderr, str_file);
> +  scoped_restore save_stdlog = make_scoped_restore (&gdb_stdlog, str_file);
> +  scoped_restore save_stdtarg = make_scoped_restore (&gdb_stdtarg, str_file);
> +  scoped_restore save_stdtargerr = make_scoped_restore (&gdb_stdtargerr,
> +							str_file);
>  

I wonder if aligning like:

     scoped_restore save_stdout
       = make_scoped_restore (&gdb_stdout, str_file);
     scoped_restore save_stderr
       = make_scoped_restore (&gdb_stderr, str_file);
     scoped_restore save_stdlog
       = make_scoped_restore (&gdb_stdlog, str_file);
     scoped_restore save_stdtarg
       = make_scoped_restore (&gdb_stdtarg, str_file);
     scoped_restore save_stdtargerr
       = make_scoped_restore (&gdb_stdtargerr, str_file);

would read better.  Can't tell on the mail client.
Up to you; just a thought.

Thanks,
Pedro Alves