This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[committed] mips-tdep: Rearrange comments in `mips_pseudo_register_type'
- From: "Maciej W. Rozycki" <macro at imgtec dot com>
- To: <gdb-patches at sourceware dot org>
- Date: Thu, 6 Oct 2016 17:01:14 +0100
- Subject: [committed] mips-tdep: Rearrange comments in `mips_pseudo_register_type'
- Authentication-results: sourceware.org; auth=none
Rearrange comments throughout `mips_pseudo_register_type', placing them
ahead the condtionals they apply to consistently.
gdb/
* mips-tdep.c (mips_pseudo_register_type): Rearrange comments
throughout.
---
gdb-mips-pseudo-type-format.diff
Index: binutils/gdb/mips-tdep.c
===================================================================
--- binutils.orig/gdb/mips-tdep.c 2016-10-03 19:14:02.950432858 +0100
+++ binutils/gdb/mips-tdep.c 2016-10-04 15:00:39.679662125 +0100
@@ -1074,9 +1074,9 @@ mips_pseudo_register_type (struct gdbarc
if (TYPE_LENGTH (rawtype) == 0)
return rawtype;
+ /* Present the floating point registers however the hardware did;
+ do not try to convert between FPU layouts. */
if (mips_float_register_p (gdbarch, rawnum))
- /* Present the floating point registers however the hardware did;
- do not try to convert between FPU layouts. */
return rawtype;
/* Use pointer types for registers if we can. For n32 we can not,
@@ -1103,19 +1103,17 @@ mips_pseudo_register_type (struct gdbarc
&& rawnum < mips_regnum (gdbarch)->dspacc + 6)))
return builtin_type (gdbarch)->builtin_int32;
+ /* The pseudo/cooked view of embedded registers is always
+ 32-bit, even if the target transfers 64-bit values for them.
+ New targets relying on XML descriptions should only transfer
+ the necessary 32 bits, but older versions of GDB expected 64,
+ so allow the target to provide 64 bits without interfering
+ with the displayed type. */
if (gdbarch_osabi (gdbarch) != GDB_OSABI_IRIX
&& gdbarch_osabi (gdbarch) != GDB_OSABI_LINUX
&& rawnum >= MIPS_EMBED_FP0_REGNUM + 32
&& rawnum <= MIPS_LAST_EMBED_REGNUM)
- {
- /* The pseudo/cooked view of embedded registers is always
- 32-bit, even if the target transfers 64-bit values for them.
- New targets relying on XML descriptions should only transfer
- the necessary 32 bits, but older versions of GDB expected 64,
- so allow the target to provide 64 bits without interfering
- with the displayed type. */
- return builtin_type (gdbarch)->builtin_int32;
- }
+ return builtin_type (gdbarch)->builtin_int32;
/* For all other registers, pass through the hardware type. */
return rawtype;